Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Peer forwarder to doc website repo. #1936

Closed
wants to merge 32 commits into from
Closed

Add Peer forwarder to doc website repo. #1936

wants to merge 32 commits into from

Conversation

carolxob
Copy link
Contributor

@carolxob carolxob commented Nov 16, 2022 •
edited
Loading

Signed-off-by: carolxob [email protected]

Description

Add Peer forwarder to doc website repo.

Issues Addressed

Addresses #1267

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@carolxob carolxob added 2 - In progress Issue/PR: The issue or PR is in progress. data-prepper labels Nov 16, 2022
@carolxob carolxob self-assigned this Nov 16, 2022
@carolxob carolxob mentioned this pull request Nov 16, 2022
Closed
19 tasks
@carolxob carolxob changed the title Add Peer forwarder to doc site repo. Add Peer forwarder to doc website repo. Nov 16, 2022
@carolxob carolxob added 3 - Tech review PR: Tech review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Nov 22, 2022
@carolxob
Copy link
Contributor Author

@dlvenable This PR is ready for tech review.

@carolxob carolxob marked this pull request as ready for review November 23, 2022 19:39
@carolxob carolxob requested a review from a team as a code owner November 23, 2022 19:39
@carolxob carolxob added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Dec 9, 2022
vagimeli
vagimeli approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carolxob See my doc review comments. Looks good overall.

_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
ariamarble
ariamarble approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@ariamarble ariamarble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after changes

@carolxob carolxob added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Dec 13, 2022
natebower
natebower requested changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carolxob Please see my comments and changes and let me know if you have any questions. Thanks!

_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
_data-prepper/peer-forwarder.md Outdated Show resolved Hide resolved
@Naarcha-AWS Naarcha-AWS added 4 - Doc review PR: Doc review in progress and removed 5 - Editorial review PR: Editorial review in progress labels Dec 27, 2022
@Naarcha-AWS Naarcha-AWS requested a review from natebower January 9, 2023 18:35
@carolxob carolxob mentioned this pull request Jan 10, 2023
Merged
1 task
@carolxob
Copy link
Contributor Author

Closing this PR to avoid confusion/difficulty with feedback provided. Replaced by #2373

@carolxob carolxob closed this Jan 10, 2023
@carolxob carolxob reopened this Jan 10, 2023
@carolxob carolxob closed this Jan 10, 2023
@hdhalter hdhalter deleted the peer-forwarder branch March 28, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asifsmohammed asifsmohammed asifsmohammed left review comments

@ariamarble ariamarble ariamarble approved these changes

@vagimeli vagimeli vagimeli approved these changes

@natebower natebower Awaiting requested review from natebower natebower is a code owner

Assignees

@carolxob carolxob

Labels
4 - Doc review PR: Doc review in progress data-prepper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@carolxob @ariamarble @asifsmohammed @natebower @vagimeli @Naarcha-AWS